Added ability to use serial with out Catkin and only cmake. #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out using catkin at all, effectively eliminating the python and catkin dependency. currently does not fix any other CMake file besides the main one, so tests still requires catkin to work.
Closed
Make example optional in CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to use serial as a cmake subdirectory and install without using catkin at all, effectively eliminating the python and catkin as a hard dependency. currently does not fix any other CMake file besides the main one, so tests still requires catkin to work. Shouldn't break any currently working code, default is to depend on catkin, added cmake option that should be toggled off for pure cmake usage.
This should effectively make python and catkin optional dependencies.